Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into moving away from Enzyme #14091

Closed
bobsilverberg opened this issue Apr 12, 2021 · 2 comments
Closed

Look into moving away from Enzyme #14091

bobsilverberg opened this issue Apr 12, 2021 · 2 comments
Assignees
Labels
repository:addons-frontend Issue relating to addons-frontend

Comments

@bobsilverberg
Copy link
Contributor

This is something we have discussed, more than once. There are incompatibilities between Enzyme and modern React, and React has no plans to try to support Enzyme moving forward.

I did a bunch of experimentation with React Testing Library back in 2020/early 2021, and I wasn't pleased with its limitations in terms of the kinds of tests we can write, but it seems like the industry is moving away from shallow rendering, so perhaps we have to bite that bullet as well.

I was reminded of this issue, and the direction the industry is taking, by this post by Dan Abramov on an issue about supporting React 17 with Enzyme.

Enzyme is also blocking us from upgrading react-redux and react-router.

@ljharb
Copy link

ljharb commented Apr 12, 2021

To be clear, React hasn't really "supported" enzyme since v16 came out. What this means isn't that enzyme can't or won't work with react; it just means that enzyme has to play catchup every time React makes a breaking change that they'd like to pretend is semver-minor.

@diox
Copy link
Member

diox commented Nov 10, 2022

Done in #14560

@diox diox closed this as completed Nov 10, 2022
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Development

No branches or pull requests

4 participants