only sync AMO policies (+ delete unused) #22255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes mozilla/addons#14791 (I thought I'd need this for mozilla/addons#14777 but probably not now)
Now policy labels are exposed they are taken into account, and only policies with, or nested under, the AMO label, or no label (mainly for sub-policies, but requirements were ambiguous) are added. Because there'll be a lot of existing CinderPolicy instances I added a clean-up too, that deletes policies that weren't present in the recent sync (assuming we've not fk'd them to anything)
Can be tested by pressing the sync button in django admin and seeing only AMO labelled policies synced. Clean-up can be tested by having CinderPolicies that won't be in the recent sync (they need to have a modified date of yesterday or prior)