Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Send correct email for keeping content disabled #1760

Open
1 task done
ioanarusiczki opened this issue Apr 19, 2024 · 4 comments
Open
1 task done

[Bug]: Send correct email for keeping content disabled #1760

ioanarusiczki opened this issue Apr 19, 2024 · 4 comments
Assignees

Comments

@ioanarusiczki
Copy link

ioanarusiczki commented Apr 19, 2024

Followup #9514

Addon is rejected/disabled after being reviewed
Developer sends an appeal
Decision is to keep content disabled , rev tool action is "clear needs human review" + Appeal checked

Email sent is:

email3

What did you expect to happen?

Correct email sent about previous decision being correct

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@eviljeff
Copy link
Member

re-adding needs:info - it's not clear what the desired UX in the reviewer tools is for this case.

@eviljeff eviljeff removed this from the 2024.05.02 milestone Apr 26, 2024
@abyrne-moz
Copy link

If we resolve this other issue, can we use the same logic for this issue?

@eviljeff
Copy link
Member

The current implementation in mozilla/addons-server#22278 removes the ability of Clear Needs Human Review to resolve jobs, so it fixes the original problem (that the reviewer tools offered something that looked like a way to reject an appeal, but it was actually an approve cinder action under the hood), but exposes that there may not be any appropriate reviewer tools action to reject an appeal. (you can't reject the same version twice!)

@diox diox removed the type:bug label May 31, 2024
@abyrne-moz
Copy link

I'll set up a meeting with AMO Eng and Ops to discuss how we want the UI to work in this instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants