Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Secondary hero shelf icons are not displayed on Chrome #1771

Closed
1 task done
ioanarusiczki opened this issue Apr 25, 2024 · 6 comments · Fixed by mozilla/addons-server#22267
Closed
1 task done
Assignees
Labels
qa:verified_fix repository:addons-frontend Issue relating to addons-frontend
Milestone

Comments

@ioanarusiczki
Copy link

ioanarusiczki commented Apr 25, 2024

What happened?

Open with Chrome
https://addons.mozilla.org/en-US/firefox/
https://addons.allizom.org/en-US/firefox/

homepage

It's not reproducible with Edge

What did you expect to happen?

Secondary Hero module icon should be displayed

I can see one icon on dev

on dev

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@ioanarusiczki ioanarusiczki added type:bug repository:addons-frontend Issue relating to addons-frontend labels Apr 25, 2024
@diox
Copy link
Member

diox commented Apr 26, 2024

What version of Chrome ? Any errors in the devtools console ? Any errors in the devtools network tab ? I can't reproduce with Version 123.0.6312.122 (Official Build) (64-bit) on Linux.

@ioanarusiczki
Copy link
Author

It's 124.0.6367.92 (Official Build) (64-bit) on Win(10) up to date and I don't see errors.

There's 2 icons which are visible
https://addons-dev.allizom.org/static-server/img/hero/icons/Mail.9a970568c203.svg
or https://addons-dev.allizom.org/static-server/img/hero/icons/Secure.2b8fa09151af.svg

Checking secondary hero shelf module with Chrome I see this:

secondary hero icons admin

@diox
Copy link
Member

diox commented May 21, 2024

Just reproduced now on Linux. Like you I can only load those 2 icons. No errors in console, the SVG loads but nothing is displayed. No issues in Firefox.

@diox diox self-assigned this May 21, 2024
@diox diox added this to the 2024.05.30 milestone May 21, 2024
@diox
Copy link
Member

diox commented May 21, 2024

Looks like if I remove the fill="context-fill" from these svg the problem goes away... Given that we aren't using those as masks I think we should do that.

@diox
Copy link
Member

diox commented May 22, 2024

(Not deployed yet on dev despite being closed, watch the slack channel for when deployments resume on dev)

@diox diox reopened this May 27, 2024
@diox diox closed this as completed May 27, 2024
@ioanarusiczki
Copy link
Author

Verified on -dev, Win(10)

Homepage:

homepage

Admin:

admin tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified_fix repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants