Skip to content
This repository has been archived by the owner on Aug 4, 2022. It is now read-only.

Should Burnham use the client activity API? #148

Open
badboy opened this issue Feb 1, 2021 · 7 comments
Open

Should Burnham use the client activity API? #148

badboy opened this issue Feb 1, 2021 · 7 comments
Labels
application Tasks related to the application component capability New capability for burnham or burnham-bigquery discussion Issues for discussing ideas for features

Comments

@badboy
Copy link
Member

badboy commented Feb 1, 2021

Is your feature request related to a problem? Please describe.

Glean now provides the client activity API.
It is not yet implemented for Python.
This allows embedding applications to trigger behavior based on client activity.
On mobile this maps to foregrounding (active) and backgrounding (inactive).
For Desktop this maps to certain activity within a certain amount of time.

The API triggers the baseline and events ping, both otherwise internal pings.

Describe the solution you'd like

Would it be useful for burnham to use this API to simulate activity and thus test Glean's expected behavior around those pings?

@hackebrot
Copy link
Collaborator

Yes, I think adding meaningful test coverage for the client activity API would be useful! 👍🏻

@hackebrot hackebrot added application Tasks related to the application component capability New capability for burnham or burnham-bigquery discussion Issues for discussing ideas for features labels Feb 1, 2021
@badboy
Copy link
Member Author

badboy commented Feb 2, 2021

Ok, let's design one! (As said, the implementation is not yet done, but should be available in the next release then)

@hackebrot
Copy link
Collaborator

Status update: @badboy will bring this to the team's attention today. 🚧

@badboy
Copy link
Member Author

badboy commented Nov 8, 2021

We currently don't have the time to pick up this work.

@hackebrot
Copy link
Collaborator

Hi @chutten! 👋🏻

From what I understand FOG is one of the consumers of the activity API. Do you have any thoughts or suggestions for how we can meaningfully test this API with burnham?

@chutten
Copy link

chutten commented Nov 15, 2021

Yup, FOG certainly is using the client activity API to signal activity (which Glean turns into "baseline" pings, as well as an opportunity to send "events" pings). Burnham could use these APIs to ensure pings are sent with the appropriate reasons at the appropriate times (and in the appropriate numbers) by simulating normal use (actives followed by inactives followed by actives) and error cases (what happens if we call active twice in a row? inactive? What if the first API call is to inactive instead of active?)

This would be important for understanding the failure modes of the client activity API and how visible they are in the data. Maybe FOG's misusing the API in a way that is presently invisible?

@hackebrot
Copy link
Collaborator

Thank you for adding your input, @chutten! 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
application Tasks related to the application component capability New capability for burnham or burnham-bigquery discussion Issues for discussing ideas for features
Projects
None yet
Development

No branches or pull requests

3 participants