Skip to content
This repository has been archived by the owner on Aug 4, 2022. It is now read-only.

Dependabot submits pull requests with incompatible versions 馃摝 #255

Open
hackebrot opened this issue Sep 3, 2021 · 2 comments
Open
Labels
bug Bugs and problems with burnham Dependabot Tasks related to managing Dependabot dependencies Tasks related to managing dependencies

Comments

@hackebrot
Copy link
Collaborator

For some reason Dependabot only updates one of the requirements files that the application uses. This then causes the CI to fail for the pull request since we check for compatible dependencies. We then need to manually perform that dependency upgrade in the other requirements file.

See for example #251 for a dependency that is referenced in the following two files:

  • application/dev-requirements.txt
  • application/requirements.txt
@hackebrot hackebrot added bug Bugs and problems with burnham dependencies Tasks related to managing dependencies Dependabot Tasks related to managing Dependabot labels Sep 3, 2021
@jklukas
Copy link
Contributor

jklukas commented Sep 3, 2021

Is it possible to ensure that requirements.txt is preferred over dev-requirements.txt so that a dep only appears in one or the other file? Or does this come from pip-compile step, and typing-extensions is pulled in transitively from two different deps?

@hackebrot
Copy link
Collaborator Author

The latter is what's happening for typing_extensions. It's a direct dependency in application/setup.py, which means it's pinned in application/requirements.txt. We use the pip-tools layered workflow feature in application/dev-requirements.in. When then generate all dependencies (application and development) in application/dev-requirements.txt using pip-compile.

-c requirements.txt
pytest>=6.1.0
coverage[toml]>=5.3.0
mypy>=0.790
flake8>=3.8.4
black>=20.8b1
types-setuptools>=57.0.2

https://github.com/mozilla/burnham/blob/main/application/dev-requirements.in#L1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs and problems with burnham Dependabot Tasks related to managing Dependabot dependencies Tasks related to managing dependencies
Projects
None yet
Development

No branches or pull requests

2 participants