Skip to content
This repository has been archived by the owner on Aug 4, 2022. It is now read-only.

Update code checks for burnham and burnham-bigquery 馃 #93

Open
hackebrot opened this issue Oct 20, 2020 · 4 comments
Open

Update code checks for burnham and burnham-bigquery 馃 #93

hackebrot opened this issue Oct 20, 2020 · 4 comments
Assignees
Labels
CircleCI Tasks related to managing CircleCI code quality Tasks related to linting, coding style, type checks docker Tasks related to building Docker images

Comments

@hackebrot
Copy link
Collaborator

We recently merged a pull-request from Dependabot that introduced incompatible dependencies for burnham (#84). As a consequence we cannot push new Docker images to GKE because the Docker workflow fails.

@jklukas correctly pointed out in #88 (comment) that we need checks that exercise the build workflow.

We currently run the following code checks on CircleCI (see config file):

  • flake8
  • mypy
  • pytest

All of these run in a tox environment. As a first step, I suggest we update the installation step to also install from requirements.txt so that any dependency conflict is detected there. I also think we should build the Docker images for pull-requests.

According to the documentation of the CircleCI orb that we use for the Docker workflows, we should be able to add a gcp-gcr/build-image step. Ideally it will only run if the respective subdirectories are modified.

@hackebrot hackebrot added code quality Tasks related to linting, coding style, type checks docker Tasks related to building Docker images CircleCI Tasks related to managing CircleCI labels Oct 20, 2020
@jrbenny35
Copy link
Collaborator

Do we want to do a pip install for each tox job? If we just want to check if everything installs maybe we can have a job just to install the requirements.txt

@hackebrot
Copy link
Collaborator Author

We probably don't need to install the packages for the flake8 environment, so we can add a skip_install = true to the tox config there. For mypy and py37 we need to install the same packages as we install in Dockerfile plus any test dependencies.

@jrbenny35
Copy link
Collaborator

Per our discussion earlier today, should I add the install to tox under the commands section? This has worked locally for me and it gets around the hash error from pip.

@hackebrot
Copy link
Collaborator Author

Yes, that'd be great! 馃憤

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CircleCI Tasks related to managing CircleCI code quality Tasks related to linting, coding style, type checks docker Tasks related to building Docker images
Projects
None yet
Development

No branches or pull requests

2 participants