Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable default review name & email #485

Open
repi opened this issue May 29, 2023 · 3 comments
Open

Configurable default review name & email #485

repi opened this issue May 29, 2023 · 3 comments

Comments

@repi
Copy link

repi commented May 29, 2023

I believe right now when doing a review through the CLI the who line is derived from git with name and email? Believe this is a good default but it would be nice to be able to override it for example with an environment variable so one can route it differently without having to edit the review after the fact.

For example we at Embark (audits) don't use our personal or work emails for the reviews, instead preferring to us our public mailing list of opensource@embark-studios.com as a central contact point.

Could for example have optional env vars for overriding the who user name and email, potentially called something like CARGO_VET_USER and CARGO_VET_EMAIL that if available replaces the git user info.

If aligned, I can probably implement and add such support in a PR.

@bholley
Copy link
Collaborator

bholley commented Jun 1, 2023

That seems sensible. @mystor WDYT?

@mystor
Copy link
Collaborator

mystor commented Jun 5, 2023

This seems reasonable to me. Using naming like CARGO_VET_NAME and CARGO_VET_EMAIL to align with the git environment variables seems like a solid environment variable naming approach (https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables#_committing).

This was referenced Sep 22, 2023
@cfm
Copy link

cfm commented Oct 19, 2023

This is a drive-by vote for environment variables over (or in addition to) the configuration file proposed by #557. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants