Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata cache invalidation issue for unpublished crate #512

Open
mystor opened this issue Jul 11, 2023 · 2 comments
Open

Metadata cache invalidation issue for unpublished crate #512

mystor opened this issue Jul 11, 2023 · 2 comments
Labels
p1 do now

Comments

@mystor
Copy link
Collaborator

mystor commented Jul 11, 2023

In https://bugzilla.mozilla.org/show_bug.cgi?id=1842331 it was discovered that we cache the unpublished metadata within the crates-io cache and don't attempt to check the index daily to invalidate this cache when a new version is published. We should probably make sure to check the index more frequently and use discovering that the crate has been published to invalidate and fetch the crate's metadata from crates.io.

@bholley
Copy link
Collaborator

bholley commented Jul 13, 2023

@mystor Is this something we should fix in a dot release?

@mystor
Copy link
Collaborator Author

mystor commented Jul 19, 2023

It's probably worth fixing, yeah. We'd need to tweak how our caching works around metadata somewhat in order to get a reasonable setup here. I don't imagine it'll be that tricky to do once I can find some time to dig into the code, but I haven't had the time for it lately.

@bholley bholley added the p1 do now label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 do now
Projects
None yet
Development

No branches or pull requests

2 participants