Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exponential backoff when retrying with tenacity #396

Open
marco-c opened this issue Jan 31, 2020 · 4 comments
Open

Use exponential backoff when retrying with tenacity #396

marco-c opened this issue Jan 31, 2020 · 4 comments
Labels
good-first-bug Good for newcomers

Comments

@marco-c
Copy link
Collaborator

marco-c commented Jan 31, 2020

We've introduced usage of tenacity in #366, but we're using normal retries. It'd be nicer to have exponential backoff.

@marco-c marco-c added the good-first-bug Good for newcomers label Jan 31, 2020
@KohilanMohanarajan
Copy link

Hello, I'm writing on behalf of my team. We wish to work on this issue as a part of our coursework for our University, and are missing the secret required to run the project locally. We'd like to work with you to help fix this issue.

@La0
Copy link
Contributor

La0 commented Feb 27, 2020

Hello, this project is unfortunately not as documented as it should to onboard new contributors.

You could do the necessary changes without running the full bot, instead relying on unit tests. That's not ideal, nor the easiest path, but doable.

Another idea if you're willing to contribute to the project would be to add support for a local configuration file in the bot. I've filed a new issue to track this: #437

Also, if you're willing to invest even more time, we obviously need some documentation for the bot aimed at developers: #438

@KohilanMohanarajan
Copy link

Is there anything we can look at to better understand how to run the project locally? As we understand, we need the backend to run in order to work on the frontend, and the backend currently isn't working for us due to the missing access to the secret using the secrets:get:project/relman/code-coverage/dev scope. Based on our understanding, we need this in order to properly run the backend.

As for the bot, when we try to run it, we keep encountering the docker: Error response from daemon: OCI runtime create failed: container_linux.go:346: starting container process caused "exec: "code-coverage-bot": executable file not found in $PATH": unknown. ERRO[0000] error waiting for container: context canceled error. How are you running the bot locally, so that we can reproduce and document it?

CCing @harsh6646, @gagankbl, @KostyaIliouk, @alexeicoreiba

@La0
Copy link
Contributor

La0 commented Mar 2, 2020

Hello @KohilanMohanarajan ,

I've added some more infos on the setup of the different projects in this PR. Once merged, you'll be able to skip the taskcluster secret part.

You can reach us directly on our Matrix instance in the code coverage channel.
Some doc to join the Matrix instance : https://wiki.mozilla.org/Matrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-bug Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants