Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(nimbus): Fix for macos integration-tests #10549

Closed
wants to merge 4 commits into from
Closed

bug(nimbus): Fix for macos integration-tests #10549

wants to merge 4 commits into from

Conversation

jrbenny35
Copy link
Contributor

@jrbenny35 jrbenny35 commented Apr 10, 2024 •
edited

Because

  • MacOS seemed to have some issues with running the integration tests

This commit

  • Adds some changes to the makefile commands and updates the readme. The real fix was done upstream

Fixes #10548

@yashikakhurana
Copy link
Contributor

let me test this locally 💪

@yashikakhurana
Copy link
Contributor

tried locally, it is still crashing on local, we are investigating more on this

@brennie brennie changed the title chore(nimbus): Fix for macos integration-tests. bug(nimbus): Fix for macos integration-tests Apr 18, 2024
@yashikakhurana
Copy link
Contributor

Okay I will pull the branch again today and will test all the commands

jaredlockhart
jaredlockhart reviewed May 6, 2024
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing it this way, can we try reverting the base image hash back to the last working one?

This PR still doesn't seem to let me run the tests in a VNC container, which is (at least for me) the important local flow for the integration tests.

@jrbenny35
Copy link
Contributor Author

Instead of doing it this way, can we try reverting the base image hash back to the last working one?

This PR still doesn't seem to let me run the tests in a VNC container, which is (at least for me) the important local flow for the integration tests.

Sure, I just dont have much time to mess with it so I can't give an ETA

@jrbenny35
Copy link
Contributor Author

Going to close this for now.

@jrbenny35 jrbenny35 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredlockhart jaredlockhart jaredlockhart left review comments

@yashikakhurana yashikakhurana Awaiting requested review from yashikakhurana

@mikewilli mikewilli Awaiting requested review from mikewilli

@brennie brennie Awaiting requested review from brennie

@jeddai jeddai Awaiting requested review from jeddai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix integration tests runs for macos
3 participants
@jrbenny35 @yashikakhurana @jaredlockhart