feat(nimbus): Conclusion recommendations migration #10672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on #10671 |
yashikakhurana
changed the title
brennie
changed the title
jrbenny35
approved these changes
May 29, 2024
brennie
approved these changes
May 29, 2024
| @@ -505,6 +505,7 @@ class NimbusExperimentType(DjangoObjectType): | |||
| conclusion_recommendations = graphene.NonNull( | |||
| graphene.List(graphene.NonNull(NimbusExperimentConclusionRecommendationEnum)) | |||
| ) | |||
|
|
|||
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 29, 2024
Because - We want to use a new conclusion recommendation field that allows user to select multiple recommendations This commit - Add the ability to select multiple (checkbox) for conclusion recommendations - Removes field from the summary page to display (radio button) - Add a new option for `None` as in the old radio button if somebody selects `None` and saves it, it isn't saving it. - Rename the conclusion recommendation config `conclusion_recommendations` option to `conclusion_recommendations_choices` to avoid name conflict with the new `conclusion_recommendations` multi-select filed Note: In the subsequent PR, will migrate the data- #10672 and remove the field altogether from frontend and backend Old UI <img width="1360" alt="Screenshot 2024-05-28 at 9 11 08 AM" src="https://github.com/mozilla/experimenter/assets/25848231/edc4de87-ac63-4c0a-abc6-426b30ebfcb5"> New UI <img width="1360" alt="Screenshot 2024-05-28 at 9 14 35 AM" src="https://github.com/mozilla/experimenter/assets/25848231/a9ff761d-52b5-429f-935b-211e865e608a"> Multiple badge <img width="1360" alt="Screenshot 2024-05-29 at 10 00 27 AM" src="https://github.com/mozilla/experimenter/assets/25848231/4c363ce4-c02d-4acf-bfb4-a551600cfbbe"> Fixes #10671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
conclusion_recommendationtoconclusion_recommendationsFixes #10668