Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable UI to use multi recommendation field #10671

Closed
data-sync-user opened this issue May 8, 2024 · 0 comments · Fixed by #10767
Closed

Enable UI to use multi recommendation field #10671

data-sync-user opened this issue May 8, 2024 · 0 comments · Fixed by #10767
Assignees
@yashikakhurana

Comments

@data-sync-user
Copy link
Collaborator

┆Issue is synchronized with this Jira Task
@yashikakhurana yashikakhurana mentioned this issue May 8, 2024
Merged
@yashikakhurana yashikakhurana mentioned this issue May 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 29, 2024
@yashikakhurana
feat(nimbus): Multi conclusion recommendation field (#10767)
d0ec42b 
Because

- We want to use a new conclusion recommendation field that allows user
to select multiple recommendations

This commit

- Add the ability to select multiple (checkbox) for conclusion
recommendations
- Removes field from the summary page to display (radio button)
- Add a new option for `None` as in the old radio button if somebody
selects `None` and saves it, it isn't saving it.
- Rename the conclusion recommendation config
`conclusion_recommendations` option to
`conclusion_recommendations_choices` to avoid name conflict with the new
`conclusion_recommendations` multi-select filed

Note: In the subsequent PR, will migrate the data-
#10672 and remove the field
altogether from frontend and backend

Old UI

<img width="1360" alt="Screenshot 2024-05-28 at 9 11 08 AM"
src="https://github.com/mozilla/experimenter/assets/25848231/edc4de87-ac63-4c0a-abc6-426b30ebfcb5">

New UI
<img width="1360" alt="Screenshot 2024-05-28 at 9 14 35 AM"
src="https://github.com/mozilla/experimenter/assets/25848231/a9ff761d-52b5-429f-935b-211e865e608a">
Multiple badge
<img width="1360" alt="Screenshot 2024-05-29 at 10 00 27 AM"
src="https://github.com/mozilla/experimenter/assets/25848231/4c363ce4-c02d-4acf-bfb4-a551600cfbbe">


Fixes #10671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yashikakhurana yashikakhurana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(nimbus): Multi conclusion recommendation field yashikakhurana/experimenter
2 participants
@yashikakhurana @data-sync-user