Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist light/dark settings #10685

Open
jaredlockhart opened this issue May 9, 2024 · 1 comment · May be fixed by #10791
Open

Persist light/dark settings #10685

jaredlockhart opened this issue May 9, 2024 · 1 comment · May be fixed by #10791
Assignees
@jaredlockhart

Comments

@jaredlockhart
Copy link
Collaborator

jaredlockhart commented May 9, 2024 •
edited by data-sync-user

Now that we have a light/dark toggle from bootstrap5 let's persist the users light/dark choice in localstorage.

┆Issue is synchronized with this Jira Task
@jaredlockhart jaredlockhart self-assigned this May 9, 2024
@mikewilli
Copy link
Contributor

Related -- we could use prefers-color-scheme to default to user's system setting for light/dark mode.

@jaredlockhart jaredlockhart mentioned this issue May 15, 2024
Merged
jaredlockhart added a commit that referenced this issue Jun 3, 2024
@jaredlockhart
feat(nimbus): persist theme switcher in new nimbus ui
fa86ed9 
Because

* We are implementing the new Nimbus UI in bootstrap 5 which supports light/dark themes
* We can add a toggle to switch themes
* We should persist the chosen theme

This commit

* Persists the chosen theme in localstorage
* Defaults to system light/dark theme

fixes #10685
@jaredlockhart jaredlockhart linked a pull request Jun 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredlockhart jaredlockhart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(nimbus): persist theme switcher in new nimbus ui mozilla/experimenter
2 participants
@jaredlockhart @mikewilli