Skip to content
This repository has been archived by the owner on Apr 11, 2019. It is now read-only.

File viewer - Let fileviewer accept any length revision number #115

Open
klahnakoski opened this issue Feb 9, 2018 · 4 comments
Open

File viewer - Let fileviewer accept any length revision number #115

klahnakoski opened this issue Feb 9, 2018 · 4 comments
Labels
view - file viewer This is the view that allows seeing tests covering a certain line on a file.

Comments

@klahnakoski
Copy link
Contributor

It is not obvious that the revision number must be 12 characters:

This works

https://charts.mozilla.org/coverage/#/file?revision=8cc2427a322c&path=js/src/wasm/WasmValidate.cpp

while this does not

https://charts.mozilla.org/coverage/#/file?revision=8cc2427a322caa1e2c09ca3957335f88e573dc7a&path=js/src/wasm/WasmValidate.cpp

@marco-c
Copy link
Collaborator

marco-c commented Feb 9, 2018

They both don't work for me.

@armenzg armenzg changed the title Let fileviewer accept any length revision number File viewer - Let fileviewer accept any length revision number Mar 1, 2018
@armenzg armenzg added the view - file viewer This is the view that allows seeing tests covering a certain line on a file. label Mar 1, 2018
@klahnakoski
Copy link
Contributor Author

Here is a new link:
https://charts.mozilla.org/coverage/#/file?revision=36c84344de23&path=js/src/wasm/WasmValidate.cpp

For if you are looking for a revision, for this file

{
    "from": "coverage",
    "where": {"and": [
        {"gt": {"repo.changeset.date": {"date": "today-2day"}}},
        {"eq": {"repo.branch.name": "mozilla-central"}},
        {"eq": {"source.file.name": "js/src/wasm/WasmValidate.cpp"}}
    ]},
    "groupby": ["repo.changeset.id12"]
}

https://activedata.allizom.org/tools/query.html#query_id=BaBq3XsR

@armenzg
Copy link
Contributor

armenzg commented Mar 7, 2018

I'm getting and XML issue when clicking on that first URL.

@klahnakoski
Copy link
Contributor Author

I did not notice that this was the old charts link. Here is the heroku link

https://firefox-code-coverage.herokuapp.com/#/file?revision=36c84344de23&path=js/src/wasm/WasmValidate.cpp

but is still do not see a problem.

armenzg pushed a commit that referenced this issue Mar 19, 2018
Query ActiveData by prefix matching revision number id. Add minimum revision number length check before AD query. Show error message if revision is too short.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
view - file viewer This is the view that allows seeing tests covering a certain line on a file.
Projects
None yet
Development

No branches or pull requests

3 participants