Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an author field #578

Open
Tracked by #164
eu9ene opened this issue May 8, 2024 · 3 comments
Open
Tracked by #164

Add an author field #578

eu9ene opened this issue May 8, 2024 · 3 comments
Labels

Comments

@eu9ene
Copy link
Collaborator

eu9ene commented May 8, 2024

We should be able to identify the author of an experiment. Currently, it's always moz-translations-wandb-bot because of the service token we use. Let's find a way to either change this one or use another field.

@eu9ene
Copy link
Collaborator Author

eu9ene commented May 8, 2024

@bhearsum I wonder if there's a way to pull a secret based on the author of the task. Then instead of using our service token we could use personal tokens to automatically identify authors in w&B.

Screenshot 2024-05-08 at 9 48 37 AM

@bhearsum
Copy link
Collaborator

bhearsum commented May 8, 2024

There's no technical reason we can't do that. The secrets are defined in the task definitions:

# Weight & Biases publication token is stored in that secret

The person who triggered the task (whether by opening a PR, making a push, or triggering an action) is available in config.params["owner"] in the transforms. So we could either substitute that into the secret in a transform, or add the secret entirely in a transform.

We'd likely want some way to gracefully handle the secret not existing. That could be checking for existence before adding it to the task definition (and fallback to disabling or a default), or it could be done somewhere in the payload. Eg: if the secret doesn't exist we implicitly disable publication.

@eu9ene
Copy link
Collaborator Author

eu9ene commented May 8, 2024

Ok, ideally we should do tricks with tokens because it turned out W&B has some nice filters like "show only my work" based on this Author field and I don't see an API to override that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants