New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move content-server experiment base logic into fxa-shared #3170
Comments
As mentioned in #3183, I was not able to move over the base experiment. If you pull down that PR and change fxa/packages/fxa-content-server/app/scripts/lib/experiments/grouping-rules/is-sampled-user.js Line 10 in 8701348
to be
It should have in theory worked because it is loading the same javascript file. However, you will get an interesting error
when you try to load the content-sever webpage. After some searching it seems to be related to babel/babel#9367. Babel seems to fail loading the class that is outside the project causing the I tried updating our webpack config to |
Connect with #3170 Unfortunately, I was not able to 100% move the base experiment in content-server over to our fxa-shared project. Please see the linked issue for the different things I tried. To spare my sanity I opted to update the experiment file to typecript and pull over the same tests from content-server. This should be enough for me to build out the experiment parts needed in the auth-server and finish #2595.
While working on #2595, I didn't want to duplicate the experiment grouping logic found in the content-server to the auth-server.
I think it makes sense to pull this base class into fxa-shared and reused in both services. However, I still think the experiment rules should still live in the respective services.
┆Issue is synchronized with this Jira Task
┆Issue Number: FXA-497
The text was updated successfully, but these errors were encountered: