Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couldn't upload draco or ktx2 glb as a custom avatar. #6209

Open
kira924age opened this issue Aug 14, 2023 · 0 comments · May be fixed by #6210
Open

Couldn't upload draco or ktx2 glb as a custom avatar. #6209

kira924age opened this issue Aug 14, 2023 · 0 comments · May be fixed by #6210
Labels
bug needs triage For bugs that have not yet been assigned a fix priority

Comments

@kira924age
Copy link

Description

GLB files using Draco or KTX2 could not be uploaded as custom avatars.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a room
  2. Click on 'Join room'
  3. Click on 'Change Avatar'
  4. Click on 'Create Avatar'
  5. Click on 'Custom GLB'
  6. Select draco/ktx2 GLB file
  7. Click on 'Save'

Expected behavior

Uploading can be done without any errors.

Screenshots

Screencast.from.2023-08-14.11-23-19.webm

Hardware

  • Device: Desktop
  • OS: Linux (Arch)
  • Browser: Firefox

Additional context

This problem is probably caused by the Loader not being set in the following code.

https://github.com/mozilla/hubs/blob/master/src/react-components/avatar-editor.js#L153-L169
@kira924age kira924age added bug needs triage For bugs that have not yet been assigned a fix priority labels Aug 14, 2023
kira924age added a commit to kira924age/hubs that referenced this issue Aug 14, 2023
@kira924age
feat: 🎸 add KTX2/Draco loader to avatar-editor
6c418fb 
✅ Closes: mozilla#6209
@kira924age kira924age linked a pull request Aug 14, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs triage For bugs that have not yet been assigned a fix priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add KTX2/Draco loader to avatar-editor kira924age/hubs
1 participant
@kira924age