Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitECS: PDFs loop back to the beginning/end when one end is reached. #6480

Open
Exairnous opened this issue Mar 20, 2024 · 0 comments
Open
Labels
bug needs triage For bugs that have not yet been assigned a fix priority

Comments

@Exairnous
Copy link
Contributor

Description
When the end of a PDF is reached in the new loader (bitECS), switching to the next page loops it back to the beginning, while in the old loader (A-Frame) it does nothing and stays at the end. The same looping behavior occurs with the previous page button when at the beginning of the document.

To Reproduce
Steps to reproduce the behavior:

  1. Open a Hubs room with the new loader enabled.
  2. Drop in a PDF.
  3. Cycle through the pages until you reach the end.
  4. Click the next page button one more time and see that it loops back to the beginning.

Expected behavior
The A-Frame loader stops at the end of the PDF and doesn't loop back to the beginning. The bitECS loader should do the same.

Hardware

  • Device: Laptop
  • OS: Linux
  • Browser: Chromium

Additional context
Having discussed this at a development meeting, looping back to the opposite end of the PDF isn't necessarily a bad thing, however it appears to be an unintentional change. Support for looping around to the other end of a PDF may be implemented in the PDF component of the Blender add-on/Spoke to allow the explicit use of this behavior.

@Exairnous Exairnous added bug needs triage For bugs that have not yet been assigned a fix priority labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage For bugs that have not yet been assigned a fix priority
Projects
None yet
Development

No branches or pull requests

1 participant