Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support RFC9000 max_idle_timeout=0 #1405

Open
marcblanchet opened this issue Jan 17, 2023 · 1 comment
Open

support RFC9000 max_idle_timeout=0 #1405

marcblanchet opened this issue Jan 17, 2023 · 1 comment

Comments

@marcblanchet
Copy link
Contributor

RFC9000
" max_idle_timeout (0x01): The maximum idle timeout is a value in
milliseconds that is encoded as an integer; see (Section 10.1).
Idle timeout is disabled when both endpoints omit this transport
parameter or specify a value of 0."

This is currently unsupported. It may be very useful for high latency or delay networks where, instead of increasing the max_idle_timeout to very large values and having all sorts of side effects, it may be more useful to support this feature.

@martinthomson
Copy link
Member

This is really a feature request for an unbounded idle timeout. That's a reasonable request. I'd be happy to review a change where the configuration was changed and we disabled the idle timeout as a result. The server side of this might have some surprises for us, but I don't foresee many problems.

Implementation-wise, the biggest question is whether we recognize Duration::from_xxx(0)/Duration::new(0, 0) as special and disable the timeout, or whether we move to Option<Duration>. The former might be easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants