Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark amplificationlimit QNS test as unsupported #1849

Open
larseggert opened this issue Apr 19, 2024 · 2 comments · May be fixed by #1875
Open

Mark amplificationlimit QNS test as unsupported #1849

larseggert opened this issue Apr 19, 2024 · 2 comments · May be fixed by #1875

Comments

@larseggert
Copy link
Collaborator

So the QNS results aren't full of failures. Until we fix #1183.

@larseggert larseggert changed the title Mark amplificationlimit as unsupported Mark amplificationlimit QNS test as unsupported Apr 19, 2024
@martinthomson
Copy link
Member

...for our server, that is.

@mxinden
Copy link
Collaborator

mxinden commented Apr 29, 2024

I am afraid we can not "mark" the test as unsupported, i.e. exit(127). Both client and server do not know the concrete testcase, but instead are told by the Interop Runner that they should execute a transfer. See def testname below.

https://github.com/quic-interop/quic-interop-runner/blob/e15a1e523d915bed008cfc6359f79e1a1458ba6f/testcases.py#L735-L742

An alternative solution would be some heuristic in neqo-client and neqo-server, though at this point, I assume #1183 is the easier solution.

@larseggert larseggert linked a pull request May 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants