Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update https://github.com/mozilla/pdf.js/wiki/Benchmarking-your-changes #11959

Closed
Snuffleupagus opened this issue Jun 2, 2020 · 1 comment
Closed

Comments

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Jun 2, 2020

Following PRs #11807 and #11241, the "Benchmarking your changes" Wiki-page needs to be updated to account for the recent changes/simplifications; I'd suggest the following changes for the respective sections (which I've successfully used in PR #11930):

$ git checkout master
$ gulp generic
$ cd test
$ node test.js --statsFile=stats/results/baseline.json --statsDelay=5000 --manifestFile=benchmark.json
$ cd ..
$ git checkout <feature-branch>
$ gulp generic
$ cd test
$ node test.js --statsFile=stats/results/current.json --statsDelay=5000 --manifestFile=benchmark.json

Finally, it's probably a good idea to also mention the --noChrome flag on that page as well.

@timvandermeij
Copy link
Contributor

Done. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants