Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraction log suppression code #11998

Closed
timvandermeij opened this issue Jun 12, 2020 · 3 comments · Fixed by #12442
Closed

Remove extraction log suppression code #11998

timvandermeij opened this issue Jun 12, 2020 · 3 comments · Fixed by #12442
Labels

Comments

@timvandermeij
Copy link
Contributor

I filed puppeteer/puppeteer#5741 before and it just got fixed upstream. If version > 3.3.0 is released, we should upgrade and remove the extraction log suppression code since it's not necessary anymore.

@adbindal
Copy link

Hi @timvandermeij, I was wondering if the issue is closed or not. If yes, does it automatically gets closed via a bot or somebody needs to do it manually?

@timvandermeij
Copy link
Contributor Author

It's not closed yet because the Puppeteer update did not work out, which is tracked in #12123. Indeed issues get closed automatically by GitHub if a pull request that lists that it fixes the issue is merged.

@timvandermeij
Copy link
Contributor Author

timvandermeij commented Aug 16, 2020

We should also be able to remove the --wait-for-browser option passing that we currently do manually after commit puppeteer/puppeteer@054d782 is released upstream since it's now supplied by default by Puppeteer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants