Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Profile not correctly resolving .aws/config file - #679 #680

Merged
merged 1 commit into from Jun 18, 2020

Conversation

gl-ahiggins
Copy link
Contributor

Possible fix for issue #679 . After building, I am successfully able to run the following:

# Can read the profile in the sops file from .aws/config
sops my-secrets.yaml
# If profile is not in the sops file, can still set AWS_PROFILE directly
AWS_PROFILE=my-account sops my-secrets.yaml

# If profile is set in BOTH env and the sops file, the sops file still takes priority to avoid breaking change.
# Here AWS_PROFILE is ignored if profile is defined in my-secrets.yaml
AWS_PROFILE=my-account sops my-secrets.yaml

@codecov-commenter
Copy link

Codecov Report

Merging #680 into develop will increase coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #680      +/-   ##
===========================================
+ Coverage    38.08%   38.23%   +0.15%     
===========================================
  Files           23       23              
  Lines         3329     3329              
===========================================
+ Hits          1268     1273       +5     
+ Misses        1931     1927       -4     
+ Partials       130      129       -1     
Impacted Files Coverage Δ
kms/keysource.go 49.04% <0.00%> (ø)
stores/flatten.go 91.52% <0.00%> (+4.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b5021...bc1567b. Read the comment docs.

@ajvb
Copy link
Contributor

ajvb commented Jun 17, 2020

@autrilla After reading the docs, this feels safe. It may cause confusion to existing users if they had some breaking difference between their ~/.aws/credentials and ~/.aws/config files, but then the aws cli would also be busted for them.

@ajvb ajvb merged commit 7ae1968 into getsops:develop Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants