Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning stderr when gpg encrypt fails #762

Merged
merged 2 commits into from Oct 29, 2020

Conversation

udayruddarraju
Copy link
Contributor

We have been having a lot of trouble investigating some failures that seem to be very flaky on a few of our projects where we use sops as a library. All we see is a message that looks like the following:

failed to encrypt new data key with master key "681E3A89EB1DAFD36EB883120A73BB48E26694D8": could not encrypt data key with PGP key: golang.org/x/crypto/openpgp error: key with fingerprint 681E3A89EB1DAFD36EB883120A73BB48E26694D8 is not available in keyring and could not be retrieved from keyserver; GPG binary error: exit status 2]

This verbose error message will hopefully be more helpful to investigate and fix the underlying issue. The current error GPG binary error: exit status 2 does not give too many details today and has been making it virtually impossible to understand the failure on a CI machine that we might or might not have access to.

@autrilla
Copy link
Contributor

Can you make this merge to develop please? Looks good to me otherwise.

@udayruddarraju udayruddarraju changed the base branch from master to develop October 29, 2020 16:12
@udayruddarraju
Copy link
Contributor Author

@autrilla done. thanks for taking a look.

Copy link
Contributor

@ajvb ajvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@autrilla autrilla merged commit 886c1ee into getsops:develop Oct 29, 2020
@ajvb ajvb mentioned this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants