Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 .deb and .rpm builds #891

Merged
merged 1 commit into from Mar 4, 2022
Merged

Add arm64 .deb and .rpm builds #891

merged 1 commit into from Mar 4, 2022

Conversation

FnTm
Copy link
Contributor

@FnTm FnTm commented Jun 22, 2021

I needed the ability to install arm64 based sops in a multi-arch Docker image, thus this PR adds the ability for the release process to generate arm64 .deb and .rpm builds.

May be a bit of an overkill with the Makefile variables, but that could make adding more architectures more DRY in the future.

I'm not a Go or Makefile expert by any stretch, but technically this seems to work, and I've verified this by installing arm64 builds in an arm64 Docker image.

This PR does not add arm64 support for sops Dockerhub images.

Fixes #595

@FnTm
Copy link
Contributor Author

FnTm commented Jun 24, 2021

There is a GPG related test failing, which I think has nothing to do with my changes.

@felixfontein
Copy link
Contributor

See #882 about the tests.

@mathew-fleisch
Copy link

Once there are arm64 go-binaries, I'd like to update the asdf plugin for sops to detect the host OS before installing https://github.com/feniix/asdf-sops
(I've done this for a few other asdf plugins)

@kbudde
Copy link

kbudde commented Jan 27, 2022

Is something blocking the merge?
Are more testers needed or more users who want it (please add 1)?

@felixfontein
Copy link
Contributor

@kbudde basically see #927

@ajvb ajvb mentioned this pull request Feb 24, 2022
@ajvb
Copy link
Contributor

ajvb commented Mar 1, 2022

I'm in favor of this and would like to get it merged before the next release. Paired with #911 this gets us to arm64 support for all of our release packages. But, we have started moving to using .github/workflows/release.yml so changes will also need to be made there.

@FnTm
Copy link
Contributor Author

FnTm commented Mar 1, 2022

@ajvb I continue to want to ship this, and can make modifications if necessary. But I'm not completely sure of what I need to change? Turning the Makefile based building into Github Actions based building?

@ajvb
Copy link
Contributor

ajvb commented Mar 1, 2022

My apologies @FnTm, I messed up. This PR looks great as-is. Would you mind merging develop into your branch so that tests are re-ran and I will get this merged.

@nklmilojevic
Copy link
Contributor

@FnTm I'll gladly rebase this and make a new PR for this if you don't have time :)

@ajvb when is the next release planned for?

@ajvb
Copy link
Contributor

ajvb commented Mar 3, 2022

@nklmilojevic Next week or the following.

@FnTm
Copy link
Contributor Author

FnTm commented Mar 4, 2022

@ajvb done, but I'm not seeing tests being run. It seems like approval is needed for the tests to be run:
image

@ajvb ajvb merged commit 9d98a82 into getsops:develop Mar 4, 2022
@ajvb
Copy link
Contributor

ajvb commented Mar 4, 2022

Thank you again @FnTm!

@FnTm
Copy link
Contributor Author

FnTm commented Mar 5, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants