diff --git a/ui/perfherder/ProgressBar.jsx b/ui/perfherder/ProgressBar.jsx index 0372bf3947b..338624ff4f2 100644 --- a/ui/perfherder/ProgressBar.jsx +++ b/ui/perfherder/ProgressBar.jsx @@ -7,21 +7,26 @@ import SimpleTooltip from '../shared/SimpleTooltip'; const ProgressBar = ({ magnitude, regression, color }) => ( + {/* the % of the bars that are colored and transparent is based on the newIsBetter metric, which determines whether the colored bar for magnitude is displayed on the left or right */} - Magnitude 1 - - Magnitude 2 - + } tooltipText="Relative magnitude of change (scale from 0 - 20%+)" diff --git a/ui/perfherder/alerts/AlertTable.jsx b/ui/perfherder/alerts/AlertTable.jsx index a330561bf6b..146cbc59996 100644 --- a/ui/perfherder/alerts/AlertTable.jsx +++ b/ui/perfherder/alerts/AlertTable.jsx @@ -248,15 +248,15 @@ export default class AlertTable extends React.Component { - -   -   - Alert Name -   -   -   - Detail Hint - Magnitude + + + + Test and platform + Previous Value + + New Value + Absolute Difference + Magnitude of Change Confidence {filteredAlerts.map(alert => ( diff --git a/ui/perfherder/alerts/AlertTableRow.jsx b/ui/perfherder/alerts/AlertTableRow.jsx index 2f9d817f374..14a4b1c1231 100644 --- a/ui/perfherder/alerts/AlertTableRow.jsx +++ b/ui/perfherder/alerts/AlertTableRow.jsx @@ -208,13 +208,9 @@ export default class AlertTableRow extends React.Component { > - + @@ -123,7 +124,6 @@ export default class CompareTable extends React.PureComponent { New Delta - {/* empty for progress bars (magnitude of difference) */} Magnitude of Difference Confidence @@ -164,7 +164,8 @@ export default class CompareTable extends React.PureComponent { this.getHashBasedId(testName, rowLevelResults.name), ) } - title={`Permalink to this test: ${rowLevelResults.name}`} + title="Permalink to this test" + aria-label={`Permalink to test ${rowLevelResults.name}`} > diff --git a/ui/shared/TruncatedText.jsx b/ui/shared/TruncatedText.jsx index 2c686a9fb16..f8a0df9f5cd 100644 --- a/ui/shared/TruncatedText.jsx +++ b/ui/shared/TruncatedText.jsx @@ -1,5 +1,3 @@ -/* eslint-disable jsx-a11y/no-noninteractive-element-interactions */ - import React from 'react'; import PropTypes from 'prop-types'; @@ -22,12 +20,13 @@ export default class TruncatedText extends React.Component { {text}

{text.length > maxLength && ( -

this.setState({ showMoreResults: !showMoreResults })} > {`show ${showMoreResults ? 'less' : 'more'}`} -

+ )} );