Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support promise-based API for browser.tabs.goBack and browser.tabs.goForward #243

Closed
infokiller opened this issue Oct 10, 2020 · 7 comments · Fixed by #244
Closed

Support promise-based API for browser.tabs.goBack and browser.tabs.goForward #243

infokiller opened this issue Oct 10, 2020 · 7 comments · Fixed by #244
Labels
contrib: good first bug contrib: mentor assigned

Comments

@infokiller
Copy link
Contributor

Seems they are supported by Firefox, but they're not in https://github.com/mozilla/webextension-polyfill/blob/master/api-metadata.json
@Rob--W
Copy link
Member

Rob--W commented Oct 10, 2020

It was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1603796.

We should indeed add those to the polyfill.

@Rob--W
Copy link
Member

Rob--W commented Oct 12, 2020

To resolve this, add the definitions for goBack and goForward to

webextension-polyfill/api-metadata.json

Line 520 in 01fb67f

"tabs": {

@infokiller
Copy link
Contributor Author

Thanks @Rob--W , is that the only required change?

@Rob--W
Copy link
Member

Rob--W commented Oct 13, 2020

Yes.

@caitmuenster caitmuenster mentioned this issue Oct 13, 2020
Open
@ariain
Copy link

ariain commented Oct 13, 2020

@Rob--W can I work on this issue??

@infokiller infokiller mentioned this issue Oct 14, 2020
Merged
@infokiller
Copy link
Contributor Author

infokiller commented Oct 14, 2020 •
edited

@ariain I already (just) submitted a PR

@ariain
Copy link

ariain commented Oct 14, 2020

okay @infokiller ....

@rpl rpl closed this as completed in #244 Oct 29, 2020
rpl pushed a commit that referenced this issue Oct 29, 2020
@infokiller
feat: Add chrome.goBack and chrome.goForward (#244)
55503f4 
Fixes #243

APIs added in Chrome 72:
- https://developer.chrome.com/extensions/tabs#method-goBack
- https://developer.chrome.com/extensions/tabs#method-goForward
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib: good first bug contrib: mentor assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add chrome.goBack and chrome.goForward
3 participants
@Rob--W @infokiller @ariain