Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SdpParserInternalError::Generic with specific errors #153

Open
na-g opened this issue Jul 2, 2019 · 0 comments
Open

Replace SdpParserInternalError::Generic with specific errors #153

na-g opened this issue Jul 2, 2019 · 0 comments
Assignees

Comments

@na-g
Copy link
Collaborator

na-g commented Jul 2, 2019

If we replace the Generic errors with specific errors, hopefully we can reduce the number of strings that 1) get created, and 2) need localization eventually. We can then test that parsing fails in the expected ways in tests. As it stands those strings are our Error API surface, and changing them could break users of the crate. This should probably be done sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants