Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should parsing an empty document yield specific error? #181

Open
na-g opened this issue Nov 8, 2019 · 3 comments
Open

Should parsing an empty document yield specific error? #181

na-g opened this issue Nov 8, 2019 · 3 comments

Comments

@na-g
Copy link
Collaborator

na-g commented Nov 8, 2019

@nils-ohlmeier, what should happen when an empty document is parsed?

@nils-ohlmeier
Copy link
Collaborator

Well we do have a test verifying that it returns an error https://github.com/mozilla/webrtc-sdp/blob/master/src/lib.rs#L1297

What would be arguments to make this a success instead?

@na-g na-g changed the title Should parsing an empty document yield an error? Should parsing an empty document yield specific error? Nov 8, 2019
@na-g
Copy link
Collaborator Author

na-g commented Nov 8, 2019

I have updated the question to ask if we want to yield a specific error (which would be matchable) if the document is empty.

@nils-ohlmeier
Copy link
Collaborator

Yes that probably makes sense to improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants