Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_media not covering valid fmt's #248

Open
q6r opened this issue Mar 9, 2021 · 3 comments
Open

parse_media not covering valid fmt's #248

q6r opened this issue Mar 9, 2021 · 3 comments

Comments

@q6r
Copy link

q6r commented Mar 9, 2021

let formats = match media {

Fails for

Line { error: Generic("format number in media line is out of range"), line: "m=audio 30000 RTP/AVP 0 8 97 2 3", line_number: 5 }

2 is ITU-T G.721
3 is GSM 06.10
from https://tools.ietf.org/html/rfc1890 there's a list of all PTs.

This may not be in the scope of the crate because of aimed to handle WebRTC SDP offers and answers

@mjfroman
Copy link
Collaborator

mjfroman commented Mar 9, 2021

One key here is that rfc1890 has been obsoleted by rfc3551. PT 2 is reserved - see section 6

@nils-ohlmeier
Copy link
Collaborator

I think this raises a good point. The parser itself should probably parse any known codecs and leave it up to application if it wants to handle these PTs.
@na-g any thoughts on this from your side?

@mjfroman mjfroman linked a pull request Mar 11, 2021 that will close this issue
@na-g
Copy link
Collaborator

na-g commented Jul 26, 2021

@nils-ohlmeier I would rather keep it constrained to what WebRTC offers unless there is a very convincing use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants