Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown rtcpfb feedback type: "rrtr“ ? #253

Open
yuebinyun opened this issue Jun 16, 2021 · 3 comments
Open

Unknown rtcpfb feedback type: "rrtr“ ? #253

yuebinyun opened this issue Jun 16, 2021 · 3 comments

Comments

@yuebinyun
Copy link

Some(x) => match *x {
    "ack" => SdpAttributeRtcpFbType::Ack,
    "ccm" => SdpAttributeRtcpFbType::Ccm,
    "nack" => SdpAttributeRtcpFbType::Nack,
    "trr-int" => SdpAttributeRtcpFbType::TrrInt,
    "goog-remb" => SdpAttributeRtcpFbType::Remb,
    "transport-cc" => SdpAttributeRtcpFbType::TransCc,
    _ => {
        return Err(SdpParserInternalError::Unsupported(format!(
            "Unknown rtcpfb feedback type: {:?}",
            x
        )));
    }
},

Unsupported { error: Unsupported("Unknown rtcpfb feedback type: "rrtr""), line: "a=rtcp-fb:111 rrtr", line_number: 26 }

@fuzzy-coats
Copy link
Contributor

@yuebinyun I am not familiar with the rrtr feedback type. Is there an RFC you could point me to?

@mstyura
Copy link

mstyura commented Sep 7, 2021

I've noticed that rrtr feedback type is used in Google Meet. Found definition of rrtr in Chromium source.

@na-g
Copy link
Collaborator

na-g commented Sep 8, 2021

Firefox issue filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1729757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants