Add support for RFC4566/RFC8866 framerate #274
Merged
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nils-ohlmeier
approved these changes
Feb 15, 2024
joaoantoniocardoso
force-pushed
the
add_framerate_attribute
branch
from
aba297d
to
3ff6f75
Compare
|
@nils-ohlmeier Thanks, I just noticed that the RFC4566 specifies that it can be a float, so I updated it accordingly. |
joaoantoniocardoso
changed the title
nils-ohlmeier
approved these changes
Feb 23, 2024
|
Hi @nils-ohlmeier, did you get any feedback for this PR? Are there other plans around this lib or something else I should do to move this further? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm new to the repo, let me know what needs to be changed so we can have this attribute added.
Closes #273