-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What's the difference with a simpler useDialogState hook #40
Comments
@mpontus I'm very interested in your answer to this as well! Thank you. |
+1 |
When component with
When your parent component is unmounted all your models will be unmounted too, but with context thay still be alive |
Hi @renchap
I'm really curious to understand why the
useModal
hook needs to use react context.Basically the way I was handling modals was using this simpler hook.
I've forked your demo and replaced with this simpler hook and the app seems to be working fine
https://codesandbox.io/s/usedialogstate-89k27?file=/src/useDialogState.js:48-258
So I was really curious why it was needed to use the context. Are there any advantages that I'm missing? or disadvantages on the simpler approach that I fail to see?
I'm kind of new to react hooks (I prefer to use Mobx for state management) and we used to have a small model to manage dialog states so it was kind of natural to me to just re-write it as a simpler hook but then I found your model and was surprised about the usage of react context.
The text was updated successfully, but these errors were encountered: