Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please considering remove smb from X-KDE-Protocols in desktop entry. #14124

Closed
merrkry opened this issue May 12, 2024 · 2 comments
Closed

Please considering remove smb from X-KDE-Protocols in desktop entry. #14124

merrkry opened this issue May 12, 2024 · 2 comments
Labels

Comments

@merrkry
Copy link

merrkry commented May 12, 2024

Some distros don't include --enable-libsmbclient in ffmpeg build. File managers like Dolphin will try use smb:// as target as mpv's current desktop entry includes smb in X-KDE-Protocols, and mpv crashes because local ffmpeg lacks smb support. As --enable-libsmbclient isn't listed as dependency here, I suggest smb should be removed from X-KDE-Protocols, to make the entry file universal on various distros.

References (may be more distros to be added here):

Important Information

  • mpv version: 0.38.0
  • Linux Distribution and Version: Archlinux
  • Source of the mpv binary: official Archlinux repo
  • If known which version of mpv introduced the problem
  • Window Manager and version: kwin 6.0.4
  • GPU model, driver and version
  • Possible screenshot or video of visual glitches

Reproduction steps

  • Connect a samba server with Dolphin
  • click to open a video with mpv
  • mpv crashes

Expected behavior

Target file should be provided with kio-fuse (under /run/user/1000/kio-fuse-*/) instead of using smb:// directly.

Actual behavior

Dolphin directly passes smb:// link to mpv, and mpv crashes because local ffmpeg build doesn't support it.

Log file

$ mpv smb://<blabla>
[ffmpeg] Protocol not found. Make sure FFmpeg is compiled with networking support.
Failed to open smb://<blabla>.
Exiting... (Errors when loading file)

Sample files

@sfan5
Copy link
Member

sfan5 commented May 12, 2024

duplicate of #8731

@CounterPillow
Copy link
Contributor

and mpv crashes because local ffmpeg build doesn't support it.

As a note of correction, this is not a crash. mpv exits on its own volition.

Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 14, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 14, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 14, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 14, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 14, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 14, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 15, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 15, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 15, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 16, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 16, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 16, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 16, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 16, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 20, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 20, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 20, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 20, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 20, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 21, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue May 22, 2024
If we can run the built mpv binary, then it is possible to use a custom
target that reads the protocols we have available in mpv and write the
mpv.desktop file based on the output. For cases where this is not
possible (e.g. cross compiling), then just install the unmodified
mpv.desktop file like before. Fixes mpv-player#8731 and fixes mpv-player#14124.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants