Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

axios v1.x bug: response header mutations via transformResponse are discarded #47

Closed
mpyw opened this issue Oct 11, 2022 · 1 comment · Fixed by #48
Closed

axios v1.x bug: response header mutations via transformResponse are discarded #47

mpyw opened this issue Oct 11, 2022 · 1 comment · Fixed by #48
Labels
bug

Comments

@mpyw
Copy link
Owner

mpyw commented Oct 11, 2022

axios@v1 support is requested in #45 and the corresponding pull-request #46 is submitted by @siketyan. However, we have identified the bug that mutated response headers unexpectedly discard their changes.

#46 (comment)

For now we'll merge #46, but at this stage it is recommended to be still kept on axios@v0. axios@v1 may not be production-ready yet.
@mpyw mpyw mentioned this issue Oct 11, 2022
Merged
@mpyw mpyw added the bug label Oct 11, 2022
@mpyw mpyw pinned this issue Oct 11, 2022
@mpyw
Copy link
Owner Author

mpyw commented Oct 11, 2022

Looks like related to axios-mock-adapter

@mpyw mpyw mentioned this issue Oct 11, 2022
Merged
@mpyw mpyw closed this as completed in #48 Oct 11, 2022
mpyw added a commit that referenced this issue Oct 11, 2022
@mpyw
chore: 🤖 Bump version for PR #48 (Issue #47)
8d6ef9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🤮 Fix axios and axios-mock-adapter compatibility issue on tests 🤮 mpyw/axios-case-converter
1 participant
@mpyw