Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

naming of fields in ConnectOptions #6

Open
vishnureddy17 opened this issue May 19, 2022 · 0 comments
Open

naming of fields in ConnectOptions #6

vishnureddy17 opened this issue May 19, 2022 · 0 comments
Assignees
@vishnureddy17

Comments

@vishnureddy17
Copy link
Member

vishnureddy17 commented May 19, 2022 •
edited

Have some doubts on what we should name things in ConnectOptions. Making an issue here to track this.

  • protocolVersion or protocolLevel? Code currently uses protocolVersion, but MQTT spec uses "protocol level"
  • brokerUrl or serverUrl?
@vishnureddy17 vishnureddy17 self-assigned this May 19, 2022
@vishnureddy17 vishnureddy17 transferred this issue from mqttjs/MQTT.js Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishnureddy17 vishnureddy17

Labels
None yet
Projects
No open projects
MQTT.js vNext
Status: Todo 📝
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vishnureddy17