Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop content emitter detection also by contentEmittersDenylist #313

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

mrmans0n
Copy link
Owner

@mrmans0n mrmans0n commented Aug 7, 2024

Simplified the detection of potential content emitters in functions, with a slight behavior change:

Before, no children would be considered if the parents were any of these set of hardcoded composables:

    setOf(
        "AlertDialog",
        "DatePickerDialog",
        "Dialog",
        "ModalBottomSheetLayout",
        "ModalBottomSheet",
        "Popup",
    )

Now, no children will be considered if the parents were any of these hardcoded composables, plus any of the composables defined in contentEmittersDenylist in the rules configuration. That way, you can get rid of false positives that might have originated with your own foundational composables.

Verified

This commit was signed with the committer’s verified signature.
SgtCoDFish Ashley Davis
@mrmans0n mrmans0n force-pushed the nacho/emitter-denylist-stops-traversing-children branch from 8c18721 to 17c9932 Compare August 7, 2024 08:47
@mrmans0n mrmans0n merged commit f9d68d5 into main Aug 7, 2024
2 checks passed
@mrmans0n mrmans0n deleted the nacho/emitter-denylist-stops-traversing-children branch August 7, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant