Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Ignore group patterns not working #357

Closed
AgentEnder opened this issue Mar 23, 2022 · 4 comments
Closed

[Regression] Ignore group patterns not working #357

AgentEnder opened this issue Mar 23, 2022 · 4 comments
Assignees
Milestone

Comments

@AgentEnder
Copy link
Contributor

Environment

  • OS Version: MacOS
  • Node.js Version: Tested on 12, 14, & 16

Actual behavior

**/!(*.ts) includes typescript files as results

Expected behavior

**/!(*.ts) doesn't include ts files

More info

This was working in 3.2.7, but broke in 3.2.8. This was discoverred while working on nrwl/nx#9283 (comment)

@mrmlnc
Copy link
Owner

mrmlnc commented May 30, 2022

Thanks for the report, @AgentEnder.

The regression related to #339. So, it must be fixed on my side :)

@AgentEnder
Copy link
Contributor Author

Ok, cool. Thanks for looking into this 🙏.

Should I close out #358, or would it be merged prior to the fix and the test enabled?

@mrmlnc mrmlnc modified the milestones: 3.3.0, 3.2.12 Jun 4, 2022
@mrmlnc
Copy link
Owner

mrmlnc commented Jun 11, 2022

@AgentEnder, thanks for the reporting issue and test for the regression 🎉.

Fixed in the master branch. Will be shipped on monday as 3.2.12.

@mrmlnc mrmlnc closed this as completed Jun 11, 2022
@jeffijoe
Copy link

Hey @mrmlnc! Any estimate on when 3.2.12 will ship? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants