Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The next performance improvements #53

Closed
3 tasks done
mrmlnc opened this issue Feb 9, 2018 · 6 comments
Closed
3 tasks done

The next performance improvements #53

mrmlnc opened this issue Feb 9, 2018 · 6 comments
Assignees

Comments

@mrmlnc
Copy link
Owner

mrmlnc commented Feb 9, 2018

Node.js

Algorithm

Code

  • Write your own package for recursive directory reading. The readdir-enhanced is poorly maintained (code, architecture).
@mrmlnc mrmlnc self-assigned this Feb 9, 2018
@mubaidr
Copy link

mubaidr commented Apr 22, 2018

Regarding the readdir-enhanced you can use the default readdir and util.promisify it.

@mrmlnc
Copy link
Owner Author

mrmlnc commented Apr 22, 2018

Unfortunately, built-in fs.readdir is low level solution. I can write my own solution (and I'll do this as mentioned above), but this will still lead to additional code. We need to be able to understand whether this directory should be read or not (!**/node_modules), whether these entries should be filtered or not and etc.

@mubaidr
Copy link

mubaidr commented Apr 22, 2018

Good point.

Also, what do you think adding an option to ignore files listed in .eslintignore? But this will require searching or specifying location of eslint ignore file.

@sindresorhus
Copy link

Relevant: https://twitter.com/bengl/status/1029196268663259136

@mrmlnc
Copy link
Owner Author

mrmlnc commented Nov 9, 2018

We can also use https://github.com/micromatch/picomatch in the future major release to reduce the time of the initialization of the filters.

@mrmlnc
Copy link
Owner Author

mrmlnc commented Apr 5, 2019

So, I can close this issue in favor:

@mrmlnc mrmlnc closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants