Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multipart: filename is double nested #303

Closed
nick-zh opened this issue Jun 15, 2022 · 2 comments
Closed

multipart: filename is double nested #303

nick-zh opened this issue Jun 15, 2022 · 2 comments

Comments

@nick-zh
Copy link

nick-zh commented Jun 15, 2022

I am using @middy/http-multipart-body-parser and they bumped from busybox:0.3.1 to busybox:1.6.0
There were no changes on middy side, but i get my file data now double nested, so instead of

{
  file: {
    filename: 'image.png',
    mimetype: 'image/png',
    encoding: '7bit',
    truncated: false,
    content: <Buffer>
  }
}

I am now getting:

{
  file: {
    filename: {
      filename: 'image.png',
      encoding: '7bit',
      mimeType: 'image/png'
    },
    mimetype: undefined,
    encoding: undefined,
    truncated: false,
    content: <Buffer>
  }
}

I am fairly certain i am using it the same way as before. I would appreciate any insight no this
Also many thanks for creating a great product 🙏

@mscdex
Copy link
Owner

mscdex commented Jun 15, 2022

The signature for the 'file' event changed, they need to update their code. They should review the list of v1.x changes as linked in the readme to see if there are other changes they need to make.

@mscdex mscdex closed this as completed Jun 15, 2022
@nick-zh
Copy link
Author

nick-zh commented Jun 15, 2022

@mscdex thx for the swift reply 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants