Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: decorate tile urls with query params #126

Open
mikey75 opened this issue Dec 23, 2022 · 1 comment
Open

Feature: decorate tile urls with query params #126

mikey75 opened this issue Dec 23, 2022 · 1 comment

Comments

@mikey75
Copy link
Contributor

mikey75 commented Dec 23, 2022

Some online tile services require api keys or other parameters in the tile url request. Perhaps it would be nice to allow AbstractTileFactory to decorate urls/request with such parameters? It could be doable by passing map of key/value pairs to factory.
Of course it is a convenience feature because you can implement it in your factory yourself, but would be nice to have in superclass and just set the parameter map.

I will try and implement it but what do you think?

@msteiger
Copy link
Owner

That's an interesting idea. Yeah sure, let's give it a try. Maybe a separate helper class that creates URLs that can be used in a superclass could be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants