Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Modern httpClient #127

Open
mikey75 opened this issue Dec 23, 2022 · 7 comments
Open

Feature: Modern httpClient #127

mikey75 opened this issue Dec 23, 2022 · 7 comments

Comments

@mikey75
Copy link
Contributor

mikey75 commented Dec 23, 2022

Maybe it would be nice to stop relying on httpurlrequest and use some decent multithreaded/async http client for tile fetching.

@msteiger
Copy link
Owner

Is there anything wrong with the current implementation? It runs multi-threaded in the background and provides tiles in an async manner. You are certainly right saying that many parts of the implementation could be modernized :-)

@mikey75
Copy link
Contributor Author

mikey75 commented Dec 31, 2022

Nothing wrong :) Just a suggestion

@intuitionbase
Copy link

intuitionbase commented Nov 30, 2023

A reason for adding a more flexible HTTP client (like Apache HttpClient) might be more flexibility with proxy configuration and also authentication. Currently, the project runs under the global proxy configuration of the VM.

For my usecase, I'd strongly appreciate the option to set a specific proxy just for JXMapViewer2. Being able to set authentication headers for the map service would be another plus.

Any chance we will see that in the future?

@msteiger
Copy link
Owner

msteiger commented Dec 3, 2023

I think that it would be good to have that flexibility - any chance you could implement it and create a PR?

@intuitionbase
Copy link

That's for my employer to decide, but it doesn't look likely, sorry...

@msteiger
Copy link
Owner

Maybe I can sketch something during the next 2-3 weeks ...

@intuitionbase
Copy link

Sounds promising! Ideally, each TileFactory would have its own HttpClient and proxy configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants