Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ClientRequest): immediate abort #464

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(ClientRequest): immediate abort #464

wants to merge 1 commit into from

Conversation

mikicho
Copy link
Contributor

@mikicho mikicho commented Oct 1, 2023 •
edited

I added failing tests.

  1. Should emit close and then abort events.
  2. Should not call to the request listeners if defined.

Currently, when we do return a mocked response, we get the following error:

TypeError: Cannot set property writableFinished of # which has only a getter

if merged, should fix #444

@kettanaito Let me know WDYT about the desired behavior, and any guidance is welcome. :)

@kettanaito
Copy link
Member

I've shared some thoughts on this in here. Would like to know what you think.

@kettanaito kettanaito mentioned this pull request Mar 12, 2024
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we run interceptor handler for destroyed(/aborted) requests?
2 participants
@mikicho @kettanaito