Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update peer dependency range #94

Merged
merged 1 commit into from Feb 20, 2023
Merged

fix: update peer dependency range #94

merged 1 commit into from Feb 20, 2023

Conversation

rajtslegr
Copy link
Contributor

issue #93

@vercel
Copy link

vercel bot commented Jan 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
msw-storybook-addon ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 4, 2023 at 11:54AM (UTC)

@DominicGBauer
Copy link

@bmvantunes can we please get this merged?

@bmvantunes
Copy link

@DominicGBauer I don't work on this project and I don't have merging rights

@philwolstenholme
Copy link

This change works for me when applied via patch-package. Without it the 'conflicting peer dependency' npm error makes things difficult unless you use the --force flag for your npm commands.

LGTM? @yannbf

@YuiSakamoto
Copy link

@yannbf
It looks fine to me.
When will this pull request be merged and released?

@kettanaito kettanaito merged commit 8ad53b0 into mswjs:main Feb 20, 2023
@kettanaito
Copy link
Member

Thanks for fixing this, @rajtslegr! 🎉

We should also bump this to > 1.0.0 < 2.0.0 sometime later to encourage people to stay up-to-date with MSW.

@rajtslegr rajtslegr deleted the fix/peer-dependency branch February 21, 2023 07:47
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

🚀 PR was released in v1.8.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants