fix: set "credentials" to "same-origin" for "ClientRequest" #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b63f916:
|
kettanaito
pushed a commit
that referenced
this pull request
Mar 15, 2022
## [0.39.2](v0.39.1...v0.39.2) (2022-03-15) ### Bug Fixes * **parseIsomorphicRequest:** bypassing cookies properly ([#1155](#1155)) ([755bc9d](755bc9d)) * remove console.log from "setRequestCookies" ([6f7ed98](6f7ed98)) * set "credentials" to "same-origin" for "ClientRequest" ([#1159](#1159)) ([c3cd80a](c3cd80a)) * set minimal supported Node.js version to 14 ([#1160](#1160)) ([d7ab139](d7ab139))
|
🎉 This PR is included in version 0.39.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kettanaito
pushed a commit
that referenced
this pull request
May 17, 2022
## [0.39.2](v0.39.1...v0.39.2) (2022-03-15) ### Bug Fixes * **parseIsomorphicRequest:** bypassing cookies properly ([#1155](#1155)) ([755bc9d](755bc9d)) * remove console.log from "setRequestCookies" ([6f7ed98](6f7ed98)) * set "credentials" to "same-origin" for "ClientRequest" ([#1159](#1159)) ([c3cd80a](c3cd80a)) * set minimal supported Node.js version to 14 ([#1160](#1160)) ([d7ab139](d7ab139))
Released: v0.40.0 🎉This has been released in v0.40.0! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
credentialsproperty on the isomorphic request must be set tosame-originwhen handlingClientRequestinstances. Those often polyfillwindow.fetchwhere that is the default value for thecredentialsfield. This also fixes the request cookies inference if we begin to respect therequest.credentialsfield as proposed in #1155).