Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set minimal supported Node.js version to 14 #1160

Merged
merged 4 commits into from Mar 11, 2022
Merged

Conversation

kettanaito
Copy link
Member

@kettanaito kettanaito commented Mar 10, 2022

Follow up to #1136

Configured CI so it runs tests/build on both Node.js 14 and 16.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 10, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b1a3163:

Sandbox Source
MSW React Configuration

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@kettanaito
Copy link
Member Author

We need to update interceptors and perhaps other ecosystem packages to also allow Node.js 14.

@kettanaito kettanaito merged commit d7ab139 into main Mar 11, 2022
@kettanaito kettanaito deleted the chore/engines-node branch March 11, 2022 14:12
@baptisteArno
Copy link

Does this fix msw@0.39.1: The engine "node" is incompatible with this module. Expected version ">=16.x". Got "14.18.1"?

@kettanaito
Copy link
Member Author

@baptisteArno, precisely.

kettanaito pushed a commit that referenced this pull request Mar 15, 2022
## [0.39.2](v0.39.1...v0.39.2) (2022-03-15)

### Bug Fixes

* **parseIsomorphicRequest:** bypassing cookies properly ([#1155](#1155)) ([755bc9d](755bc9d))
* remove console.log from "setRequestCookies" ([6f7ed98](6f7ed98))
* set "credentials" to "same-origin" for "ClientRequest" ([#1159](#1159)) ([c3cd80a](c3cd80a))
* set minimal supported Node.js version to 14 ([#1160](#1160)) ([d7ab139](d7ab139))
@kettanaito
Copy link
Member Author

🎉 This PR is included in version 0.39.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thedavidprice
Copy link

Thank you @kettanaito Count me in if ever there's a way I can reciprocate collaboration!

kettanaito pushed a commit that referenced this pull request May 17, 2022
## [0.39.2](v0.39.1...v0.39.2) (2022-03-15)

### Bug Fixes

* **parseIsomorphicRequest:** bypassing cookies properly ([#1155](#1155)) ([755bc9d](755bc9d))
* remove console.log from "setRequestCookies" ([6f7ed98](6f7ed98))
* set "credentials" to "same-origin" for "ClientRequest" ([#1159](#1159)) ([c3cd80a](c3cd80a))
* set minimal supported Node.js version to 14 ([#1160](#1160)) ([d7ab139](d7ab139))
@kettanaito
Copy link
Member Author

Released: v0.40.0 🎉

This has been released in v0.40.0!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants