Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support typescript 4.7.x #1256

Merged
merged 1 commit into from May 26, 2022
Merged

fix: support typescript 4.7.x #1256

merged 1 commit into from May 26, 2022

Conversation

shiftkey
Copy link
Contributor

Based upon the work in #1245 I've taken a shot at seeing if this can be upgraded cleanly to 4.7.2

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aa87e2e:

Sandbox Source
MSW React Configuration

@shiftkey shiftkey marked this pull request as ready for review May 26, 2022 16:12
@kettanaito
Copy link
Member

kettanaito commented May 26, 2022 •
edited

Hey, @shiftkey. That's just fantastic! Thank you for giving this a try. Let's see if the CI passes with the new TS version.

Also, I don't mean to pry but do you use MSW in GitHub in any way? I'm asking because it'd mean a lot to me to know that the platform where I develop my ideas actually uses one of them! I'd also love to display GitHub's logo on our website if that's the case and if GitHub is okay with that, obviously.

kettanaito
kettanaito approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are green 🎉 Let's have this improvement rolled out. Maybe it could make it to the daily automated release yet.

Welcome to the contributors, @shiftkey!

@kettanaito kettanaito merged commit b020270 into mswjs:main May 26, 2022
@shiftkey shiftkey deleted the add-support-for-ts-4-7 branch May 27, 2022 12:58
@kettanaito
Copy link
Member

Released: v0.41.1 🎉

This has been released in v0.41.1!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.

@kettanaito kettanaito mentioned this pull request May 28, 2022
Closed
4 tasks
@nnnnat nnnnat mentioned this pull request Aug 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kettanaito kettanaito kettanaito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shiftkey @kettanaito