fix(setupServer): reference interceptors to support fast refresh #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1c6adc9:
|
kettanaito
force-pushed
the
fix/setup-server-interceptor-instances
branch
from
12cbb5d
to
f756ff3
Compare
kettanaito
force-pushed
the
fix/setup-server-interceptor-instances
branch
from
f756ff3
to
1c6adc9
Compare
kettanaito
changed the title
Released: v0.42.2 🎉This has been released in v0.42.2! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Since the interceptors for Node were instantiated in a different module, the HMR path never touched that module, resulting in those interceptor instances (and their listeners) persisting across hot reloads.
In this change, I'm passing the interceptors class references to the
createSetupServerfactory instead of accepting instances, and instantiating them in thesetupServercall itself.I've tested this on a fresh
with-mswNext template and the issue about responding to the same request twice is resolved with this change.