Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send the event data directly to and from the service worker without stringifying #1317

Closed
1 task
95th opened this issue Jul 9, 2022 · 2 comments · Fixed by #1320
Closed
1 task

Send the event data directly to and from the service worker without stringifying #1317

95th opened this issue Jul 9, 2022 · 2 comments · Fixed by #1320
Labels

Comments

@95th
Copy link
Collaborator

95th commented Jul 9, 2022

Scope

Improves an existing behavior

Compatibility

  • This is a breaking change

Feature description

Send the event data directly to and from the service worker without stringifying

@95th 95th added the feature label Jul 9, 2022
@kettanaito
Copy link
Member

This makes sense. I think stringification is there for historical reasons, from the early days of this library being a prototype. I've noticed that you can send objects (and even streams/buffers) over BroadcastChannel to the worker. That's what we've started doing since #1288, so I don't see a reason why we should still stringify request information in the MessageChannel between the worker and the client.

@kettanaito
Copy link
Member

Released: v0.44.0 🎉

This has been released in v0.44.0!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants